Add keycloak IDP hint and logout endpoint #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
reviewed
May 27, 2024
Added the field (from Open Forms) to the base model. The view code to look up the config value was already present.
This definitely works with keycloak, it should probably work with other OpenID providers but those are yet untested.
Added disclaimer about possible non-standard behaviour and preferred approach to send the user agent to the logout endpoint.
sergei-maertens
force-pushed
the
feature/42-add-keycloak-idp-hint
branch
from
67ce1c7
to
69c6706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
oidc_kc_idp_hintmodel field to the base config, so those can be removed in subclasses once this is releasedoidc_op_logout_endpointand utility to log out a user based on their ID token, with testsI figured this would be nice to ship in 0.17.0 too now that a lot of code has been reorganized :)